Conversation
Implement ITransparencyService and AzureCtsTransparencyService to handle transparency in COSE Sign1 messages using Azure's Code Transparency Service (CTS). Add extension methods for transparency operations, including making messages transparent, checking for transparency headers, and managing receipts. Introduce new tests to validate functionality and update project files for necessary dependencies.
Added two new test commands for the CoseSign1.Transparent.Tests and CoseSign1.Transparent.CTS.Tests projects to the dotnet.yml file, enabling their execution during the build process.
JeromySt
commented
Apr 27, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This commit introduces additional exception handling for specific exceptions, improving robustness across multiple classes. In the `CoseSign1TransparencyMessageExtensions` class, receipts are now encoded directly into a CBOR array using `CborWriter`, eliminating the need for an intermediate list. This change simplifies the code and ensures efficient handling of existing receipts while maintaining the logic for managing unprotected headers.
…osoft/CoseSignTool into users/jstatia/verifiability
Improved clarity and correctness in the documentation for `CoseIndirectSignature`, `CoseSign1.Abstractions`, and `CoseSign1.Certificates`. Added new tests for `AzureCtsTransparencyServiceExtensions` and introduced the class to facilitate integration with the CoseSign1 transparency ecosystem. Added comprehensive documentation for `CoseSign1.Transparent`, including features and usage. Made minor formatting and grammatical corrections, updated the project file structure, and fixed a typo in the README.
JoeBussell
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Transparency to CoseSign1 libraries to leverage services such as Azure Code Transparency Service
Added an implementation of ITransparencyService for Azure CTS.